Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled Memory Allocation Failure / Invalid Write #698

Closed
zachmse opened this issue Sep 22, 2023 · 0 comments
Closed

Unhandled Memory Allocation Failure / Invalid Write #698

zachmse opened this issue Sep 22, 2023 · 0 comments

Comments

@zachmse
Copy link

zachmse commented Sep 22, 2023 •
edited

Openclos.c calls ExAllocatePoolWithTag (line 1955) without checking to see if the allocation was successful. In cases where allocation failed, the subsequent call to RtlAppendUnicodeToString (line 1957) results in an invalid write.

npcap/packetWin7/npf/npf/Openclos.c

Lines 1955 to 1957 in afd6abf

pFiltMod->AdapterName.Buffer = ExAllocatePoolWithTag(NPF_NONPAGED, pFiltMod->AdapterName.MaximumLength, NPF_UNICODE_BUFFER_TAG);
pFiltMod->AdapterName.Length = 0;
RtlAppendUnicodeToString(&pFiltMod->AdapterName, AdapterName->Buffer + DEVICE_PATH_CCH);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zachmse