Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npcap installer may install duplicate root certificates. #692

Closed
dmiller-nmap opened this issue Aug 17, 2023 · 0 comments
Closed

Npcap installer may install duplicate root certificates. #692

dmiller-nmap opened this issue Aug 17, 2023 · 0 comments
Labels
bug installation Issues with installing Npcap

Comments

@dmiller-nmap
Copy link
Contributor

Npcap's installer adds certificates to the system's trust store in order to avoid issues with signature validation on some systems. Using certutil.exe to add a certificate when one with the same thumbprint already exists will result in a duplicate if the existing cert has additional context info like FriendlyName. These duplicate certs can cause problems for software using Windows APIs like System.ServiceModel.Security.SecurityUtils.GetCertificateFromStoreCore, which fails if it does not find exactly one certificate that matches.

Our intended fix is for the installer to first check if a certificate exists in the store before attempting to install it. Also, if a duplicate without FriendlyName is found, we will delete that duplicate.

@dmiller-nmap dmiller-nmap added bug installation Issues with installing Npcap labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug installation Issues with installing Npcap
Projects
None yet
Development

No branches or pull requests

1 participant